Surefire test filtering support #1
Conversation
| @@ -46,23 +51,19 @@ test { | |||
|
|
|||
| shadowJar { | |||
| exclude 'META-INF/maven/**' | |||
|
|
|||
| dependencies { | |||
There was a problem hiding this comment.
Certain dependencies (e.g. junitPlatformLaungher) are needed with their original (unshadowed) package names (see why here and here)
The changes made to the shadowJar config, as well as disabling both checkExportedPackage and checkArtifact, was the only way I managed to get it work. Leaving the current config resulted in a bunch of ClassNotFoundExceptions in tests, because the classes from junitPlatformLauncher, surefireApi etc. would, unsurprisingly, not be found on the runtime test classpath.
Please advise on how this requirement should properly be handled. If the packages absolutely must be shadowed, I can introduce a proxy at runtime, but that just adds unnecessary complexity IMHO.
| PostDiscoveryFilter postDiscoveryFilter = findPostDiscoveryFilter(request); | ||
| PostDiscoveryFilter replacement = initialize(postDiscoveryFilter); | ||
| if (replacement != postDiscoveryFilter) { | ||
| replaceFilter(request, postDiscoveryFilter, replacement); |
There was a problem hiding this comment.
This if statement is not yet used (will be needed for Gradle filtering)
| try { | ||
| if (SurefireTestNameFilter.appliesTo(discoveryRequest)) { | ||
| return new SurefireTestNameFilter(discoveryRequest); | ||
| } |
There was a problem hiding this comment.
Another else if branch could essentially be added here if we also want to introduce a filter based on custom ArchUnit properties, like the ticket suggests
crizzis
force-pushed
the
feature/issue-641-surefire
branch
from
d4d6021
to
d1cea3d
Compare
crizzis
force-pushed
the
feature/issue-641-surefire
branch
from
d1cea3d
to
8364e32
Compare
Signed-off-by: Krzysztof Sierszeń krzysztof.sierszen@digitalnewagency.com